🎨Computational backend: stability improvements step7 #8400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8400 +/- ##
==========================================
- Coverage 87.91% 87.79% -0.12%
==========================================
Files 1951 1523 -428
Lines 75961 63264 -12697
Branches 1336 674 -662
==========================================
- Hits 66779 55545 -11234
+ Misses 8782 7485 -1297
+ Partials 400 234 -166
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for f924987. ✅ Passed Jobs With Interesting Signals
|
|
pcrespov
approved these changes
Sep 22, 2025
sanderegg
requested review from
bisgaard-itis,
matusdrobuliak66 and
wvangeit
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the computational backend stability by reducing connection concurrency and improving error handling. The changes focus on preventing connection overload and ensuring better exception handling for disconnected scheduler scenarios.
- Reduced maximum concurrent client connections from 10 to 1 to minimize connection load
- Added exception handling for dask client cancellation errors to improve robustness
- Enhanced task resource requirements to ensure minimum CPU allocation meets dask worker threading requirements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/director-v2/src/simcore_service_director_v2/modules/dask_client.py | Reduces max concurrent connections and adds exception handling for dask client cancellation errors |
| services/autoscaling/src/simcore_service_autoscaling/modules/cluster_scaling/_provider_computational.py | Ensures minimum CPU allocation of 1.0 for tasks to match dask worker threading requirements |
| packages/service-library/tests/redis/test_semaphore_decorator.py | Updates test configurations and adds new test cases for semaphore functionality |
| packages/service-library/src/servicelib/redis/_semaphore_decorator.py | Adds configurable expected lock time parameter to semaphore decorators |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/director-v2/src/simcore_service_director_v2/modules/dask_client.py
Show resolved
Hide resolved
sanderegg
deleted the
computational-backend/stability-improvements-step7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
ensure concurrency is kept to the minimum.
Adds an additional exception that is risen when the scheduler is not responding as expected.
Related issue/s
How to test
Dev-ops